Comments on: Improving your validation code — a refactoring exercise http://jonkruger.com/blog/2010/03/11/improving-your-validation-code-a-refactoring-exercise/ Fri, 18 May 2012 01:22:10 +0000 http://wordpress.org/?v=2.7 hourly 1 By: Jon Kruger http://jonkruger.com/blog/2010/03/11/improving-your-validation-code-a-refactoring-exercise/comment-page-1/#comment-4883 Jon Kruger Fri, 12 Mar 2010 14:24:05 +0000 http://jonkruger.com/blog/?p=504#comment-4883 @Darrell, Actually I do pretty much exactly what you outlined in your comment. I just didn't put an example of it in the post (I think I just forgot!). Thanks for pointing that out. @Darrell,

Actually I do pretty much exactly what you outlined in your comment. I just didn’t put an example of it in the post (I think I just forgot!). Thanks for pointing that out.

]]> By: Darrell Mozingo http://jonkruger.com/blog/2010/03/11/improving-your-validation-code-a-refactoring-exercise/comment-page-1/#comment-4882 Darrell Mozingo Fri, 12 Mar 2010 14:19:01 +0000 http://jonkruger.com/blog/?p=504#comment-4882 I like how you stepped through the though process here - it's a lot better than showing the end result. I wouldn't worry about the method name underscores, either. I'm starting to use them in more and more of my code (and if you ever get a chance to take JP Boodhoo's Nothin' But .Net Bootcamp, you'll get used to them real quick!). Have you thought about using a generic specification? public interface ISpecification { bool IsSatisfiedBy(T entity); } Then have your registry/IoC tool look for all ISpecification's and run through them, passing in your order. You could modify it to take in the ValidationErrorsCollection and each specification could add messages to it. Then you can break up your order validator a bit (though I know you said you weren't too concerned about it), along with your tests. It'd help when a certain validation rule gets a bit too large or complex. Just a thought. I like how you stepped through the though process here - it’s a lot better than showing the end result. I wouldn’t worry about the method name underscores, either. I’m starting to use them in more and more of my code (and if you ever get a chance to take JP Boodhoo’s Nothin’ But .Net Bootcamp, you’ll get used to them real quick!).

Have you thought about using a generic specification?

public interface ISpecification {
bool IsSatisfiedBy(T entity);
}

Then have your registry/IoC tool look for all ISpecification’s and run through them, passing in your order. You could modify it to take in the ValidationErrorsCollection and each specification could add messages to it. Then you can break up your order validator a bit (though I know you said you weren’t too concerned about it), along with your tests. It’d help when a certain validation rule gets a bit too large or complex.

Just a thought.

]]>